Skip to content

Conversation

@mberhault
Copy link
Contributor

@mberhault mberhault commented Jun 6, 2018

Add the --enterprise-encryption flag to debug commands that open
rocksdb. The flag is as specified in the start command.

There are a few TODOs left:

  • support the ldb tool somehow
  • add tests for this, it'll need to be interactive tests in ccl/

Release note: None

@mberhault mberhault requested a review from bdarnell June 6, 2018 19:32
@mberhault mberhault requested a review from a team as a code owner June 6, 2018 19:32
@mberhault mberhault requested a review from a team June 6, 2018 19:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mberhault mberhault mentioned this pull request Jun 6, 2018
29 tasks
@mberhault
Copy link
Contributor Author

I think support LDB just involves doing the same dance we're doing with the rocksdb::Options. Basically just replacing the env. It'll be a bit more annoying as we need to find and use the --db flag, but it should still be fairly straightforward.

@bdarnell
Copy link
Contributor

bdarnell commented Jun 6, 2018

:lgtm:


Review status: 0 of 4 files reviewed at latest revision, all discussions resolved, all commit checks successful.


pkg/cli/debug.go, line 61 at r1 (raw file):

// DebugKeysCmd dumps keys.
var DebugKeysCmd = &cobra.Command{

Why do the individual commands need to be exported? Isn't the list the only thing that's referenced from outside the package?


Comments from Reviewable

Add the `--enterprise-encryption` flag to debug commands that open
rocksdb. The flag is as specified in the start command.

There are a few TODOs left:
* support the ldb tool somethow
* add tests for this, it'll need to be interactive tests in ccl/

Release note: None
@mberhault mberhault force-pushed the marc/debug_encrypted_stores branch from d38c902 to 5605f08 Compare June 6, 2018 22:30
@mberhault
Copy link
Contributor Author

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


pkg/cli/debug.go, line 61 at r1 (raw file):

Previously, bdarnell (Ben Darnell) wrote…

Why do the individual commands need to be exported? Isn't the list the only thing that's referenced from outside the package?

uh. yes. nevermind. Done.


Comments from Reviewable

@mberhault
Copy link
Contributor Author

bors r+

craig bot pushed a commit that referenced this pull request Jun 6, 2018
26477: cli: support encrypted stores in debug commands. r=mberhault a=mberhault

Add the `--enterprise-encryption` flag to debug commands that open
rocksdb. The flag is as specified in the start command.

There are a few TODOs left:
* support the ldb tool somehow
* add tests for this, it'll need to be interactive tests in ccl/

Release note: None

Co-authored-by: marc <marc@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Jun 6, 2018

Build succeeded

@craig craig bot merged commit 5605f08 into cockroachdb:master Jun 6, 2018
@mberhault mberhault deleted the marc/debug_encrypted_stores branch June 7, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants