cli: use the right context for logging on signal#26716
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 14, 2018
Merged
cli: use the right context for logging on signal#26716craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
We were using a long-gone context with a potentially finished span, leading to log-after-finish crashes. Fixes cockroachdb#26715 Release note: None
Member
a-robinson
approved these changes
Jun 14, 2018
Contributor
|
this may need backporting |
Contributor
Author
|
the problem was introduced after 2.0 bors r+ Review status: Comments from Reviewable |
Contributor
I see a call to |
Contributor
Build succeeded |
Contributor
Author
Ah indeed, but that's a different enough bug. Will send a fix for that too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using a long-gone context with a potentially finished span,
leading to log-after-finish crashes.
Fixes #26715
Release note: None