Remember the ReplicaID in multiraft.group. #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM with minor comments |
Whenever the ReplicaID changes, the raft group must be dropped and recreated so raft knows about this. Fixes TestRaftRemoveRace.
removeGroup needs to modify this map in places where the local variable is not easily accessible.
bdarnell
force-pushed
the
reset-replica-id
branch
from
fb04a5a
to
4d8dc76
Compare
bdarnell
added a commit
that referenced
this pull request
Oct 14, 2015
Remember the ReplicaID in multiraft.group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the ReplicaID changes, the raft group must be dropped
and recreated so raft knows about this.
Fixes TestRaftRemoveRace.