Commits on Aug 31, 2018

1. cli: periodically flush csv/tsv output …

   The "sinkless" version of changefeeds continuously streams back
   results to the user over pgwire. Prior to this patch, this data could
   not be consumed effectively with `cockroach sql` using the tsv/csv
   output, because the tsv/csv formatter buffers rows internally.
   
   This patch makes tsv/csv output in `cockroach sql` an effective way to
   consume changefeeds by ensuring an upper bound on the time rows stays
   buffered inside the formatter. The flush period is fixed to 5 seconds.
   
   For context, all the other formatters except for `table` are
   line-buffered and thus flush on every row. `table` is a world of its
   own which buffers *all* the rows until the query is complete, and that
   is unlikely to change any time soon, so this patch doesn't touch that
   either.
   
   Release note (cli change): The `csv` and `tsv` formats for `cockroach`
   commands that output result rows now buffer data for a maximum of 5
   seconds. This makes it possible to e.g. view SQL changefeeds
   interactively with `cockroach sql` and `cockroach demo`.

   

   knz committed Aug 31, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 1dc7788
   • Browse repository at this point

   Copy the full SHA

   1dc7788 View commit details

   Browse the repository at this point in the history