cli: include gossip_alerts in debug zip #28692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
Member
|
This change is |
petermattis
approved these changes
Aug 16, 2018
Collaborator
petermattis
left a comment
petermattis
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
pkg/cli/zip.go, line 107 at r1 (raw file):
gossipLName = base + "/gossip/liveness" gossipNName = base + "/gossip/nodes" alertsName = base + "/alerts"
Not /gossip/alerts?
tbg
commented
Aug 16, 2018
Member
Author
tbg
left a comment
tbg
left a comment
There was a problem hiding this comment.
bors r=petermattis
Reviewable status:
pkg/cli/zip.go, line 107 at r1 (raw file):
Previously, petermattis (Peter Mattis) wrote…
Not
/gossip/alerts?
I almost did that, but the idea is that you're going to want to look at that one first, so I didn't want to hide it somewhere down below. We can revisit this.
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None