Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add hex option to debug keys #29328

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Conversation

tbg
Copy link
Member

@tbg tbg commented Aug 30, 2018

This was used in #29252 and I imagine I'll want to use it again whenever
we see the consistency checker fail in the future.

Release note: None

@tbg tbg requested a review from a team as a code owner August 30, 2018 08:54
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This was used in cockroachdb#29252 and I imagine I'll want to use it again whenever
we see the consistency checker fail in the future.

Release note: None
Copy link
Contributor

@a-robinson a-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@tbg
Copy link
Member Author

tbg commented Aug 30, 2018

bors r=a-robinson

@craig
Copy link
Contributor

craig bot commented Aug 30, 2018

Build failed (retrying...)

craig bot pushed a commit that referenced this pull request Aug 30, 2018
29328: cli: add hex option to debug keys r=a-robinson a=tschottdorf

This was used in #29252 and I imagine I'll want to use it again whenever
we see the consistency checker fail in the future.

Release note: None

Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
@craig
Copy link
Contributor

craig bot commented Aug 30, 2018

Build succeeded

@craig craig bot merged commit 8aca169 into cockroachdb:master Aug 30, 2018
@tbg tbg deleted the fix/debug-keys-hex branch September 21, 2018 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants