release-2.1: storage: Avoid using different qps measurements in StoreRebalancer #31379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's better to use the same measurement for everything, especially because it's the one that was used to compute the store's total QPS. Fixes cockroachdb#31303 Release note: None
|
This change is |
bdarnell
approved these changes
Oct 15, 2018
|
LGTM
On Mon, Oct 15, 2018 at 7:39 PM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/31379>
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#31379 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE135Gloh2yjS2jSF-aEy9_QOt8PFjuzks5ulMhPgaJpZM4Xcz7->
.
--
…-- Tobias
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #31324.
/cc @cockroachdb/release
It's better to use the same measurement for everything, especially
because it's the one that was used to compute the store's total QPS.
Fixes #31303
Release note: None