kv: properly mark r/o txns as committed #31599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readonly txns have a special commit path. This path wasn't marking the txn as committed correctly, which had a couple of consequences: - db.Txn() would potentially try to commit again, in case the closure already did it - the txn.aborted metric was incremented Fixes cockroachdb#31595 Release note: Fix a bug causing committed read-only txns to be counted as aborted in the metrics.
|
This change is |
nvanbenschoten
approved these changes
Oct 18, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
andreimatei
commented
Oct 18, 2018
Build failed |
|
flake is #31126
bors r+
…On Thu, Oct 18, 2018 at 5:11 PM craig[bot] ***@***.***> wrote:
Build failed
- GitHub CI (Cockroach)
<https://teamcity.cockroachdb.com/viewLog.html?buildId=974539&buildTypeId=Cockroach_UnitTests>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31599 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXBcZrSmogo7Whnx-77KVclCEN9yDMoks5umO6RgaJpZM4XubdP>
.
|
craig bot
pushed a commit
that referenced
this pull request
Oct 18, 2018
31599: kv: properly mark r/o txns as committed r=andreimatei a=andreimatei Readonly txns have a special commit path. This path wasn't marking the txn as committed correctly, which had a couple of consequences: - db.Txn() would potentially try to commit again, in case the closure already did it - the txn.aborted metric was incremented Fixes #31595 Release note: Fix a bug causing committed read-only txns to be counted as aborted in the metrics. Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Oct 19, 2018
31608: release-2.1: kv: properly mark r/o txns as committed r=andreimatei a=andreimatei Backport 1/1 commits from #31599. /cc @cockroachdb/release --- Readonly txns have a special commit path. This path wasn't marking the txn as committed correctly, which had a couple of consequences: - db.Txn() would potentially try to commit again, in case the closure already did it - the txn.aborted metric was incremented Fixes #31595 Release note: Fix a bug causing committed read-only txns to be counted as aborted in the metrics. Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readonly txns have a special commit path. This path wasn't marking the
txn as committed correctly, which had a couple of consequences:
already did it
Fixes #31595
Release note: Fix a bug causing committed read-only txns to be counted
as aborted in the metrics.