Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interval: don't use interval btree by default #32584

Merged

Conversation

nvanbenschoten
Copy link
Member

This slipped into 5b1ad68, which was not the intention of the change.
There aren't any known issues with the btree implementation, but we
weren't intending on using it and should have been deliberate about
the change if we wanted to make it.

Release note: None

This slipped into 5b1ad68, which was not the intention of the change.
There aren't any known issues with the btree implementation, but we
weren't intending on using it and should have been deliberate about
the change if we wanted to make it.

Release note: None
@nvanbenschoten nvanbenschoten requested a review from tbg November 26, 2018 00:01
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@nvanbenschoten
Copy link
Member Author

bors r+

craig bot pushed a commit that referenced this pull request Nov 26, 2018
32584: interval: don't use interval btree by default r=nvanbenschoten a=nvanbenschoten

This slipped into 5b1ad68, which was not the intention of the change.
There aren't any known issues with the btree implementation, but we
weren't intending on using it and should have been deliberate about
the change if we wanted to make it.

Release note: None

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig
Copy link
Contributor

craig bot commented Nov 26, 2018

Build succeeded

@craig craig bot merged commit 8808aea into cockroachdb:master Nov 26, 2018
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/intervalTreeNoBtree branch November 27, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants