release-2.1: sql: prevent a crash and add telemetry for an assertion #32742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
LGTM |
We got reports in the wild that CockroachDB crashes upon SHOW SESSIONS/QUERIES due to an invalid session ID in a ListSessions response. An invalid session ID should never happen; also conceptually it makes no sense because if a session exists (insofar that it gets reported by Listsessions) it must hav ean ID. However I was not able to find how an invalid session ID could be created, if at all. So the root cause of the problem remains uncovered. In the meantime, this patch prevents a crash when encountering an invalid session ID. nil entries are transformed to SQL NULLs, and non-nil entries with a non-16 size are reported as `<invalid>`. Also the values are recorded and reported in telemetry. Release note (bug fix): CockroachDB does not longer crash when encountering an internal error related to invalid entries in the output of SHOW SESSIONs.
knz
force-pushed
the
backport2.1-32713
branch
from
5d63271 to
3460b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #32713.
/cc @cockroachdb/release
Informs #32517.