remove in-place magic from truncate() #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| truncateOne := func(args roachpb.Request) (bool, []func(), error) { | ||
| // requests after truncation is returned. | ||
| func truncate(ba roachpb.BatchRequest, rs roachpb.RSpan) (roachpb.BatchRequest, int, error) { | ||
| truncateOne := func(args roachpb.Request) (bool /* omit? */, roachpb.Span, error) { |
There was a problem hiding this comment.
I'd reverse the bool and make it ok instead of omit. It's weird to see return false, emptySpan, util.Errorf(...) when false normally means that we are returning a real value.
There was a problem hiding this comment.
I like omit->ok, but I'm still going to return false on errors because that's the zero value.
There was a problem hiding this comment.
Yes, that's what I mean. When there's an error, ok should clearly be false, both because it's the zero value and semantically correct. If it's omit, true is arguably more correct but it's unusual to return a non-zero value with an error.
|
LGTM |
tbg
added a commit
that referenced
this pull request
Dec 3, 2015
remove in-place magic from truncate()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shelled out from wip on #2716.