storage: un-starve TestReplicateQueueDownReplicate #33013
Conversation
Before this change, > make test PKG=./pkg/storage/ TESTS=TestReplicateQueueDownReplicate > TESTFLAGS='-count 10' takes ~109s on my laptop. After this change, it takes ~18s. This is in line with a test failure on CI which looked like the test had just never managed to schedule the goroutines that matter in time for things to wrap up. Fixes cockroachdb#32256. Release note: None
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
pkg/storage/replicate_queue_test.go, line 198 at r1 (raw file):
ServerArgs: base.TestServerArgs{ ScanMinIdleTime: 10 * time.Millisecond, ScanMaxIdleTime: 10 * time.Millisecond,
Note that you set these to 1ms back in mid July. Did you experiment with larger values (e.g. 100ms)? I'm wondering how 10ms was arrived at.
There was a problem hiding this comment.
bors r=petermattis
Reviewable status:
pkg/storage/replicate_queue_test.go, line 198 at r1 (raw file):
Previously, petermattis (Peter Mattis) wrote…
Note that you set these to 1ms back in mid July. Did you experiment with larger values (e.g. 100ms)? I'm wondering how 10ms was arrived at.
When I set these to 1ms, it was because they had implicitly been bumped to 1s. With 100ms, I get ~64s for 10 runs. Based on that, 10ms is reasonable enough.
33013: storage: un-starve TestReplicateQueueDownReplicate r=petermattis a=tbg Before this change, > make test PKG=./pkg/storage/ TESTS=TestReplicateQueueDownReplicate > TESTFLAGS='-count 10' takes ~109s on my laptop. After this change, it takes ~18s. This is in line with a test failure on CI which looked like the test had just never managed to schedule the goroutines that matter in time for things to wrap up. Fixes #32256. Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Build succeeded |
Before this change,
takes ~109s on my laptop. After this change, it takes ~18s.
This is in line with a test failure on CI which looked like the test
had just never managed to schedule the goroutines that matter in time
for things to wrap up.
Fixes #32256.
Release note: None