sql: make pg_catalog OIDs stable and refer to the descriptor IDs directly #33420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This change is |
knz
reviewed
Jan 3, 2019
There was a problem hiding this comment.
Thank you for this PR. The change to give different IDs to each virtual table is very good.
I still want to investigate further how to structure the IDs so that they are not all over the place (and so that they can become stable over time). I will come back to you.
Reviewable status:
complete! 0 of 0 LGTMs obtained
…ctly Databases and tables OID use descriptor id directly. It's fine because we create the id with sql.GenerateUniqueDescID. Virtual tables use static negative ID. Do not use the same math.MaxUint32 anymore. Release note(sql change): Databases and tables pg_catalog OID values are changed.
hueypark
commented
Jan 3, 2019
There was a problem hiding this comment.
Thank you for your review.
Please note that the method of assigning ID has been improved.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature for #32940
Can handle in future #32963, #32964
Databases and tables OID use descriptor id directly. It's fine because we create the id with sql.GenerateUniqueDescID.
Virtual tables use static negative ID. Do not use the same math.MaxUint32 anymore.
Release note(sql change): Databases and tables pg_catalog OID values are changed.