acceptance: re-enable bank/zerosum-restart #33549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Looks like this still needs some work. |
This was forgotten, cockroachdb#30064 is long fixed :fingers_crossed: Release note: None
tbg
force-pushed
the
acceptance/unskip-30064
branch
from
e46a105
to
1b3fe9c
Compare
|
Added the random error to the already random whitelist... |
petermattis
approved these changes
Jan 10, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
pkg/cmd/roachtest/bank.go, line 348 at r1 (raw file):
func isExpectedRelocateError(err error) bool { return testutils.IsError(err, "(descriptor changed|unable to remove replica .* which is not present|unable to add replica .* which is already present|received invalid ChangeReplicasTrigger .* to remove self|breaker open)")
I'm actually a bit surprised by breaker open.
nvanbenschoten
approved these changes
Jan 10, 2019
tbg
commented
Jan 11, 2019
There was a problem hiding this comment.
TFTRs!
bors r=petermattis
Reviewable status:
pkg/cmd/roachtest/bank.go, line 348 at r1 (raw file):
Previously, petermattis (Peter Mattis) wrote…
I'm actually a bit surprised by
breaker open.
Agreed, filed #33657 to follow up.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was forgotten, #30064 is long fixed :fingers_crossed:
Release note: None