storage: reduce log spam from MaybeGossipSystemConfig #33552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All replicas were logging at level 2 the fact that they're not the ones who should be gossipping the system config. I've increased it to 3 to separate it since it's a way more common message than others around at level 2 (most replias are not in charge of the system config). Also remove a stale comment. Release note: None
|
This change is |
nvanbenschoten
approved these changes
Jan 8, 2019
|
Bors r+
…On Tue, Jan 8, 2019, 1:18 AM Nathan VanBenschoten ***@***.*** wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#33552 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXBca93nnAfhLcDxwrnz7blzHLQDEmxks5vBDhEgaJpZM4Z0Qo7>
.
|
craig bot
pushed a commit
that referenced
this pull request
Jan 8, 2019
33552: storage: reduce log spam from MaybeGossipSystemConfig r=andreimatei a=andreimatei All replicas were logging at level 2 the fact that they're not the ones who should be gossipping the system config. I've increased it to 3 to separate it since it's a way more common message than others around at level 2 (most replias are not in charge of the system config). Also remove a stale comment. Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All replicas were logging at level 2 the fact that they're not the ones
who should be gossipping the system config. I've increased it to 3 to
separate it since it's a way more common message than others around at
level 2 (most replias are not in charge of the system config).
Also remove a stale comment.
Release note: None