Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: run fewer splits in kv/splits #33563

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

tbg
Copy link
Member

@tbg tbg commented Jan 8, 2019

Closes #30832.

Release note: None

@tbg tbg requested a review from petermattis January 8, 2019 14:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

I recall this test being stable at 500k for a while. Do we have enough test history to see if something changed? Or is the flakiness random?

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@tbg
Copy link
Member Author

tbg commented Jan 8, 2019

The test has an 80% success rate, we only have history for about a month

image

There are indication that "things changed" with the introduction of closed timestamps as well as some of the reworking of the internal data structures (spanlatch manager, tscache, etc). I think with a bit of elbow grease we could get back to the original 500k. However, absent a concerted push this doesn't seem to make much sense.
It's also possible that unquiescing behavior changed. I believe that the cluster collapses only if it enters a death spiral in which, say, the liveness range gets so unresponsive that all epoch-based ranges (i.e. all of them) unquiesce and it goes straight to hell from there.

bors r=petermattis

craig bot pushed a commit that referenced this pull request Jan 8, 2019
33563: roachtest: run fewer splits in kv/splits r=petermattis a=tbg

Closes #30832.

Release note: None

Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
@craig
Copy link
Contributor

craig bot commented Jan 8, 2019

Build succeeded

@craig craig bot merged commit 83b962f into cockroachdb:master Jan 8, 2019
@tbg tbg deleted the roachtest/quiesce-test branch January 10, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants