sql: add proper telemetry for arrays of JSON #35704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20190313-json-arrays
branch
2 times, most recently
from
2f9e021 to
c04ff44
Compare
justinj
reviewed
Mar 14, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @justinj, @knz, and @RaduBerinde)
pkg/sql/coltypes/arrays.go, line 52 at r1 (raw file):
// canBeInArrayColType returns true if the given T is a valid // element type for an array column type.
I think the issueNum, while fairly self-explanatory, could be mentioned in this comment.
Arrays of JSON are not supported but the errors did not link attempted uses to issue cockroachdb#23468. This patch fixes it. Release note: None
knz
force-pushed
the
20190313-json-arrays
branch
from
c04ff44 to
f01a4ba
Compare
Good idea! Done. |
|
TFYR! bors r+ |
Build failed |
|
failed on #35549 |
craig bot
pushed a commit
that referenced
this pull request
Mar 14, 2019
35714: sql,opt: enrich the reported errors, avoid "naked" panics r=knz a=knz First commit from #35704. Informs https://github.com/cockroachlabs/registration/issues/203. The `optbuilder` package's error handling was deficient in two ways: - it would fail assertions with a hard panic and cause a node shutdown; - it did not enrich errors with a suitable pg error code in many cases, including missing references to issues that track unimplemented features. This patch fixes the former by introducing a new primitive `assertionErrorf` that creates a pgerror with CodeInternalError (this is picked up in telemetry automatically). It fixes the latter by adding the missing error codes. Where applicable, errors have been either picked from the HP code, or from PostgreSQL. In the latter cases the code was also backported to the HP for consistency. Additionally, a linter is added to prevent the addition of new undecorated panics. Release note: None Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays of JSON are not supported but the errors did not
link attempted uses to issue #23468. This patch fixes it.