sql: Fix issues causing failures in SQLSmith #37057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
There are (at least) 3 issues that are currently causing the SQLSmith nightly test to fail: 1. Issue cockroachdb#36830 - panic: windowNode can't be run in local mode 2. Panic when calling builtin functions with ANY parameters 3. Panic when json_build_object is called with DBitArray datum This commit fixes cockroachdb#2 and cockroachdb#3: 2. SQLSmith now generates a random datum type when it encounters an ANY param. 3. Add DBitArray to the list of datums handled by the json_build_object function. In addition, the fix for cockroachdb#2 exposed a SQLSmith bug, where it ws unable to parse the type names of existing tables. The fix is to change typeFromName to use parser.ParseType. After these fixes, and once issue cockroachdb#36830 is fixed, the SQLSmith tests should start passing again in nightlies. Release note (sql change): Fix panic when json_build_object is called with BIT/VARBIT values.
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 24, 2019
37057: sql: Fix issues causing failures in SQLSmith r=andy-kimball a=andy-kimball There are (at least) 3 issues that are currently causing the SQLSmith nightly test to fail: 1. Issue #36830 - panic: windowNode can't be run in local mode 2. Panic when calling builtin functions with ANY parameters 3. Panic when json_build_object is called with DBitArray datum This commit fixes #2 and #3: 2. SQLSmith now generates a random datum type when it encounters an ANY param. 3. Add DBitArray to the list of datums handled by the json_build_object function. In addition, the fix for #2 exposed a SQLSmith bug, where it ws unable to parse the type names of existing tables. The fix is to change typeFromName to use parser.ParseType. After these fixes, and once issue #36830 is fixed, the SQLSmith tests should start passing again in nightlies. Release note (sql change): Fix panic when json_build_object is called with BIT/VARBIT values. Co-authored-by: Andrew Kimball <andyk@cockroachlabs.com>
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are (at least) 3 issues that are currently causing the SQLSmith nightly
test to fail:
This commit fixes #2 and #3:
In addition, the fix for #2 exposed a SQLSmith bug, where it ws unable to
parse the type names of existing tables. The fix is to change typeFromName to
use parser.ParseType.
After these fixes, and once issue #36830 is fixed, the SQLSmith tests should
start passing again in nightlies.
Release note (sql change): Fix panic when json_build_object is called with
BIT/VARBIT values.