release-19.1: de-flake tests #37076
Merged
release-19.1: de-flake tests #37076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, this test would fail `stressrace` after a few dozen iterations. The root cause of this was the invalid call to `t.Parallel()`, which this patch removes. Additionally, this patch adapts TimeUntilStoreDead for each test case to avoid flakes, and removes a previous hack obviated by this simplification. Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Member
|
This change is |
Sub-tests that invoke `t.Parallel()` get to run concurrently with their parent test, and may be delayed arbitrarily past beyond the end of the termination of the parent test (including beyond the execution of its `defer` calls). This means it's unsafe to call `t.Parallel()` with e.g. `leaktest.AfterTest()`. This patch removes `t.Parallel` from the test in `sql/physical_props_test.go` and modifies `pkg/rpc/TestGRPCKeepaliveFailureFailsInflightRPCs` to use a wait group instead. Release note: None
…ightRPCs Since this now runs on its own goroutine, it is invalid for it to access the surrounding `testing.T`. This patch moves the code so that `t` is clearly out of scope. Release note: None
This suggests using `sync.WaitGroup` instead. Release note: None
knz
force-pushed
the
backport19.1-36952-37072
branch
from
667e01e to
c9b31da
Compare
tbg
approved these changes
Apr 25, 2019
Member
|
@knz I think this is good to go now, the release shas have been picked. |
Contributor
Author
|
yeah I'm not going to be too trigger happy on this one, I'll merge when the release is actually out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(will merge after 19.1 is released)
Fixes #37114.
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release