sql: don't exclude unvalidated check constraints #37366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
May 7, 2019
Previously, as of 19.1, AllActiveAndInactiveChecks(), which gets check constraints for ALTER TABLE as well as SHOW CONSTRAINT, etc., excluded unvalidated checks on the table descriptor, under the assumption that all checks would be validated once they'd been added to the table descriptor. This was to avoid double-counting constraints that were both on the table descriptor and in the list of mutations. This caused unvalidated checks added in earlier versions to disappear (though they are still on the table descriptor itself, and are still enforced for writes). This PR fixes the issue by only excluding `Validating` checks on the table descriptor to avoid double-counting. Release note (bug fix): Fixes bug where unvalidated check constraints disappear from the output of SHOW CONSTRAINT and cannot be referenced in ALTER TABLE after upgrading to 19.1.
|
I updated the PR. I realized the previous approach (deduplicating by name, or even name and expression) doesn't work, since this function gets called in validating the uniqueness of constraint names before they're added. What will work is just filtering out |
dt
approved these changes
May 10, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 10, 2019
37366: sql: don't exclude unvalidated check constraints r=lucy-zhang a=lucy-zhang Previously, as of 19.1, AllActiveAndInactiveChecks(), which gets check constraints for ALTER TABLE as well as SHOW CONSTRAINT, etc., excluded unvalidated checks on the table descriptor, under the assumption that all checks would be validated once they'd been added to the table descriptor. This was to avoid double-counting constraints that were both on the table descriptor and in the list of mutations. This caused unvalidated checks added in earlier versions to disappear (though they are still on the table descriptor itself, and are still enforced for writes). This PR fixes the issue by only excluding `Validating` checks on the table descriptor to avoid double-counting. Fixes #37285. Release note (bug fix): Fixes bug where unvalidated check constraints disappear from the output of SHOW CONSTRAINT and cannot be referenced in ALTER TABLE after upgrading to 19.1. 37450: parser: Add IMPORT INTO prototype syntax r=dt a=dt Breaking this out of the implementation PR. Release note: None Co-authored-by: Lucy Zhang <lucy-zhang@users.noreply.github.com> Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, as of 19.1, AllActiveAndInactiveChecks(), which gets check
constraints for ALTER TABLE as well as SHOW CONSTRAINT, etc., excluded
unvalidated checks on the table descriptor, under the assumption that all
checks would be validated once they'd been added to the table descriptor. This
was to avoid double-counting constraints that were both on the table descriptor
and in the list of mutations. This caused unvalidated checks added in earlier
versions to disappear (though they are still on the table descriptor itself,
and are still enforced for writes). This PR fixes the issue by only excluding
Validatingchecks on the table descriptor to avoid double-counting.Fixes #37285.
Release note (bug fix): Fixes bug where unvalidated check constraints disappear
from the output of SHOW CONSTRAINT and cannot be referenced in ALTER TABLE
after upgrading to 19.1.