Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings: move parallel commits behind cluster version gate #37777

Merged
merged 1 commit into from
May 23, 2019
Merged

settings: move parallel commits behind cluster version gate #37777

merged 1 commit into from
May 23, 2019

Conversation

nvanbenschoten
Copy link
Member

See #36983.

Release note: None

@nvanbenschoten nvanbenschoten requested review from andreimatei and a team May 23, 2019 18:10
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/parCommitVersion branch from 3590836 to de2d6ea Compare May 23, 2019 18:11
andreimatei
andreimatei reviewed May 23, 2019
View reviewed changes
Copy link
Contributor

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)

@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/parCommitVersion branch from de2d6ea to 159893e Compare May 23, 2019 18:19
@nvanbenschoten nvanbenschoten mentioned this pull request May 23, 2019
Closed
@nvanbenschoten
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented May 23, 2019

Build failed

@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/parCommitVersion branch from 159893e to a93da08 Compare May 23, 2019 19:27
@nvanbenschoten
Copy link
Member Author

Needed to regen docs/generated/settings/settings.html.

bors r+

craig bot pushed a commit that referenced this pull request May 23, 2019
@nvanbenschoten
Merge #37777
25967d2 
37777: settings: move parallel commits behind cluster version gate r=nvanbenschoten a=nvanbenschoten

See #36983.

Release note: None

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig
Copy link
Contributor

craig bot commented May 23, 2019

Build succeeded

@craig craig bot merged commit a93da08 into cockroachdb:master May 23, 2019
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/parCommitVersion branch May 23, 2019 20:21
@knz knz mentioned this pull request Nov 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreimatei andreimatei andreimatei left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvanbenschoten @cockroach-teamcity @andreimatei