release-19.1: distsqlpb: whitelist node unavailability errors #37789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Prior to this patch, a distsql gateway would crash if it received an error payload of a type it didn't know about. This is unfair to the user, as an error (regardless of payload) is just an error. This patch removes the panic and produces a valid error (with a Sentry report, so we can investigate further). Release note: None
A node being down during distsql query processing is a legitimate (and expected) error. It needs not be reported to telemetry. Release note: None
Prior to cockroachdb#37367, a node unavailable error was reported in distsql as a pgerror with code "internal" (assertion). Change cockroachdb#37367 changes this to report node availability using a different code. Meanwhile, the schema change logic wants to be able to retry if a schema change appears to fail due a node going down. Since this is not exercised in CI (only in nightly test), cockroachdb#37367 forgot about that. This commit completes the fix. (Note that this dance with error codes are band-aids; a more robust fix is upcoming in cockroachdb#37765 and following.) Release note: None
andreimatei
approved these changes
May 28, 2019
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #37367.
Backport 1/1 commits from #37800.
/cc @cockroachdb/release
Fixes #37215.
A node being down during distsql query processing is a legitimate (and
expected) error. It needs not be reported to telemetry.