Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: replace unexpected txn state assertion with error #37867

Merged
merged 1 commit into from
May 26, 2019
Merged

kv: replace unexpected txn state assertion with error #37867

merged 1 commit into from
May 26, 2019

Conversation

nvanbenschoten
Copy link
Member

See #37866.

This has been failing in roachtests like #37488. This will make it easier to debug until the issue is fixed.

Release note: None

@nvanbenschoten
kv: replace unexpected txn state assertion with error
2c3c06b 
See cockroachdb#37866.

This has been failing in roachtests like cockroachdb#37488. This will make
it easier to debug until the issue is fixed.

Release note: None
@nvanbenschoten nvanbenschoten requested review from tbg and a team May 26, 2019 20:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten mentioned this pull request May 26, 2019
Closed
tbg
tbg approved these changes May 26, 2019
View reviewed changes
Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to take a shot at debugging this this week. 🤞 that you don't have to worry about it when you return.

@nvanbenschoten
Copy link
Member Author

I'll try to take a shot at debugging this this week.

Thanks! 🤞

bors r+

craig bot pushed a commit that referenced this pull request May 26, 2019
@nvanbenschoten
Merge #37867
4e1ebb2 
37867: kv: replace unexpected txn state assertion with error r=nvanbenschoten a=nvanbenschoten

See #37866.

This has been failing in roachtests like #37488. This will make it easier to debug until the issue is fixed.

Release note: None

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig
Copy link
Contributor

craig bot commented May 26, 2019

Build succeeded

@craig craig bot merged commit 2c3c06b into cockroachdb:master May 26, 2019
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/errorNotAssertion branch June 3, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvanbenschoten @cockroach-teamcity @tbg