release-2.1: opt: fix issue with dangling pointer in statisticsBuilder #38075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the statisticsBuilder was using an invalid pointer to update statistics for some multi-column stats in the local table statistics cache. The fix is to re-fetch the pointer to the stats just before updating them, in case the previously fetched address is no longer valid. This problem is very hard to reproduce, so I had to use the somewhat complex query from the issue for a regression test. Fixes cockroachdb#37953 Release note: None
|
This change is |
RaduBerinde
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #37983.
/cc @cockroachdb/release
This commit fixes an issue where the
statisticsBuilderwas usingan invalid pointer to update statistics for some multi-column stats
in the local table statistics cache. The fix is to re-fetch the
pointer to the stats just before updating them, in case the
previously fetched address is no longer valid.
This problem is very hard to reproduce, so I had to use the somewhat
complex query from the issue for a regression test.
Fixes #37953
Release note: None