log: use prefix in std loggers #38275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distinguish loggers we inject into stdlib packages by prepending a custom prefix to all their lines. Otherwise it's very confusing looking at the file:line tags on their lines as they don't seem to make sense. Release note: None
|
This change is |
ajwerner
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
andreimatei
commented
Jun 19, 2019
craig bot
pushed a commit
that referenced
this pull request
Jun 19, 2019
38275: log: use prefix in std loggers r=andreimatei a=andreimatei Distinguish loggers we inject into stdlib packages by prepending a custom prefix to all their lines. Otherwise it's very confusing looking at the file:line tags on their lines as they don't seem to make sense. Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distinguish loggers we inject into stdlib packages by prepending a
custom prefix to all their lines. Otherwise it's very confusing looking
at the file:line tags on their lines as they don't seem to make sense.
Release note: None