util/quotapool: various features and fixes #38587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/quotapool-len
branch
from
d3b052f
to
3855f91
Compare
ajwerner
changed the title
This code is being pulled from ongoing work on admission control but this change seemed isolated enough to warrant a separate PR. Release note: None
This change is used in upcoming work on admission control but felt sufficiently isolated to warrant its own PR. This function is especially useful for recording metrics after an acquisition has occurred. Release note: None
ajwerner
force-pushed
the
ajwerner/quotapool-len
branch
from
6d0662f
to
8dcbaa3
Compare
andreimatei
reviewed
Jul 8, 2019
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 9, 2019
38587: util/quotapool: various features and fixes r=ajwerner a=ajwerner This code is being pulled from ongoing work on admission control but this change seemed isolated enough to warrant a separate PR. Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is being pulled from ongoing work on admission control but this
change seemed isolated enough to warrant a separate PR.
Release note: None