opt: specify hash joins in EXPLAIN (OPT) #38827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In EXPLAIN (OPT), joins that have no mention (like `merge` or `lookup`) are executed as hash joins. Make this explicit, for the benefit of usage outside of the opt team. Release note: None
|
This change is |
jordanlewis
approved these changes
Jul 11, 2019
justinj
reviewed
Jul 11, 2019
There was a problem hiding this comment.
just looked at expr_format.go and peeked at a couple of the tests,
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @justinj and @rytaft)
Is it? I thought we advertise the simple |
My understanding is that we were planning to deprecate simple |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 11, 2019
38663: sql: add support for NOT VALID Foreign Key constraints r=Tyler314 a=Tyler314 Implemented the support of not validating an ALTER TABLE foreign key constraint to a table. Within alter_table.go we set the validity of the foreign key reference to be unvalidated, and within shema_changer.go we then check the case where the foreign key being added is unvalidated and do not check its validity. This allows users to create a reference between two non-empty tables who's entries don't comply with the constraint when it's first added. 38827: opt: specify hash joins in EXPLAIN (OPT) r=RaduBerinde a=RaduBerinde In EXPLAIN (OPT), joins that have no mention (like `merge` or `lookup`) are executed as hash joins. Make this explicit, for the benefit of usage outside of the opt team. Release note: None Co-authored-by: craig[bot] <bors@cockroachlabs.com> Co-authored-by: Tyler314 <tyler@cockroachlabs.com> Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In EXPLAIN (OPT), joins that have no mention (like
mergeorlookup) are executed as hash joins. Make this explicit, for thebenefit of usage outside of the opt team.
Release note: None