exec: handle nulls in AVG aggregator #38828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarkAggregator/AVG/hash/Decimal/groupSize=1/hasNulls=false/numInputBatches=64-12 20 72817604 ns/op 7.20 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=1/hasNulls=true/numInputBatches=64-12 20 67807960 ns/op 7.73 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=2/hasNulls=false/numInputBatches=64-12 30 45907478 ns/op 11.42 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=2/hasNulls=true/numInputBatches=64-12 30 44468409 ns/op 11.79 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=512/hasNulls=false/numInputBatches=64-12 200 8712009 ns/op 60.18 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=512/hasNulls=true/numInputBatches=64-12 200 8852871 ns/op 59.22 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=1024/hasNulls=false/numInputBatches=64-12 200 9058353 ns/op 57.88 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=1024/hasNulls=true/numInputBatches=64-12 200 9289322 ns/op 56.44 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=1/hasNulls=false/numInputBatches=64-12 20 67161015 ns/op 7.81 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=1/hasNulls=true/numInputBatches=64-12 20 60712202 ns/op 8.64 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=2/hasNulls=false/numInputBatches=64-12 30 40953924 ns/op 12.80 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=2/hasNulls=true/numInputBatches=64-12 30 39335420 ns/op 13.33 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=512/hasNulls=false/numInputBatches=64-12 300 4201872 ns/op 124.77 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=512/hasNulls=true/numInputBatches=64-12 300 4202353 ns/op 124.76 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=1024/hasNulls=false/numInputBatches=64-12 500 3982187 ns/op 131.66 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=1024/hasNulls=true/numInputBatches=64-12 500 3766494 ns/op 139.20 MB/s Release note: None
|
This change is |
|
Thanks to a few of the lessons learned from implementing the other aggregators, the benchmark stats are actually better with null handling than without. |
solongordon
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @solongordon)
|
💯 |
craig bot
pushed a commit
that referenced
this pull request
Jul 11, 2019
38828: exec: handle nulls in AVG aggregator r=rafiss a=rafiss closes #37738 The random aggregation test uses float64 now so that AVG can be included in this test, until #38823 can be addressed. ``` BenchmarkAggregator/AVG/hash/Decimal/groupSize=1/hasNulls=false/numInputBatches=64-12 20 72817604 ns/op 7.20 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=1/hasNulls=true/numInputBatches=64-12 20 67807960 ns/op 7.73 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=2/hasNulls=false/numInputBatches=64-12 30 45907478 ns/op 11.42 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=2/hasNulls=true/numInputBatches=64-12 30 44468409 ns/op 11.79 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=512/hasNulls=false/numInputBatches=64-12 200 8712009 ns/op 60.18 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=512/hasNulls=true/numInputBatches=64-12 200 8852871 ns/op 59.22 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=1024/hasNulls=false/numInputBatches=64-12 200 9058353 ns/op 57.88 MB/s BenchmarkAggregator/AVG/hash/Decimal/groupSize=1024/hasNulls=true/numInputBatches=64-12 200 9289322 ns/op 56.44 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=1/hasNulls=false/numInputBatches=64-12 20 67161015 ns/op 7.81 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=1/hasNulls=true/numInputBatches=64-12 20 60712202 ns/op 8.64 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=2/hasNulls=false/numInputBatches=64-12 30 40953924 ns/op 12.80 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=2/hasNulls=true/numInputBatches=64-12 30 39335420 ns/op 13.33 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=512/hasNulls=false/numInputBatches=64-12 300 4201872 ns/op 124.77 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=512/hasNulls=true/numInputBatches=64-12 300 4202353 ns/op 124.76 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=1024/hasNulls=false/numInputBatches=64-12 500 3982187 ns/op 131.66 MB/s BenchmarkAggregator/AVG/ordered/Decimal/groupSize=1024/hasNulls=true/numInputBatches=64-12 500 3766494 ns/op 139.20 MB/s ``` Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #37738
The random aggregation test uses float64 now so that AVG can be included in this test, until #38823 can be addressed.
Release note: None