workload/tpcc: avoid validating foreign keys after dataset generation #38834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foreign key validation was adding a significant amount of time to the initialization of TPC-C. This was especially true on very large datasets. This commit uses the new (as of cockroachdb#38663) ability to create Foreign Key constraints in the Unvalidated state using the NOT VALID syntax to avoid this extra work. This will work with old versions of CockroachDB as well, because the NOT VALID syntax has been around for a very long time, it was just ignored up until cockroachdb#38663. Release note: None
|
This change is |
danhhz
approved these changes
Jul 11, 2019
|
bors r=danhhz |
craig bot
pushed a commit
that referenced
this pull request
Jul 11, 2019
38834: workload/tpcc: avoid validating foreign keys after dataset generation r=danhhz a=nvanbenschoten Foreign key validation was adding a significant amount of time to the initialization of TPC-C. This was especially true on very large datasets. This commit uses the new (as of #38663) ability to create Foreign Key constraints in the `Unvalidated` state using the `NOT VALID` syntax to avoid this extra work. This will work with old versions of CockroachDB as well because the `NOT VALID` syntax has been around for a very long time, it was just ignored up until #38663. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Build succeeded |
|
Follow up Q: my mental model of this is that after fixtures import finishes, normal INSERT/UPDATE/DELETES writes to these tables still get FK checks. it's only the data in the table at the time of FK addition that doesn't get checked. is that right? |
|
@danhhz yes, that's correct |
|
Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foreign key validation was adding a significant amount of time to the initialization of TPC-C. This was especially true on very large datasets. This commit uses the new (as of #38663) ability to create Foreign Key constraints in the
Unvalidatedstate using theNOT VALIDsyntax to avoid this extra work.This will work with old versions of CockroachDB as well because the
NOT VALIDsyntax has been around for a very long time, it was just ignored up until #38663.Release note: None