Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libroach: avoid recycling encrypted WALs #38868

Merged
merged 1 commit into from
Jul 24, 2019

Commits on Jul 24, 2019

  1. libroach: avoid recycling encrypted WALs

    RocksDB fails recovery if there are any non-empty WALs that have zero
    readable entries. So we need to make sure
    `EncryptedEnv::ReuseWritableFile()` cannot produce such files, even if
    an inopportune crash happens. We do not know how to achieve this while
    still changing the encryption key for the recycled WAL, so for now this
    PR works around the problem in `EncryptedEnv::ReuseWritableFile()` by
    faking recycling.
    
    Release note: None
    ajkr committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    57619ba View commit details
    Browse the repository at this point in the history