Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: Fixing bug in tighter span generation for lookup join. #38899

Merged
merged 1 commit into from
Jul 17, 2019
Merged

sql: Fixing bug in tighter span generation for lookup join. #38899

merged 1 commit into from
Jul 17, 2019

Conversation

rohany
Copy link
Contributor

@rohany rohany commented Jul 16, 2019

The original change tried to split up families when using a secondary index, which isn't correct.

Release note: None

@rohany rohany requested review from solongordon and a team July 16, 2019 15:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rohany
Copy link
Contributor Author

rohany commented Jul 17, 2019

bors r+

craig bot pushed a commit that referenced this pull request Jul 17, 2019
@rohany
Merge #38899
5a38247 
38899: sql: Fixing bug in tighter span generation for lookup join. r=rohany a=rohany

The original change tried to split up families when using a secondary index, which isn't correct.

Release note: None

Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
@craig
Copy link
Contributor

craig bot commented Jul 17, 2019

Build succeeded

@craig craig bot merged commit b5babf5 into cockroachdb:master Jul 17, 2019
@knz knz mentioned this pull request Nov 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solongordon solongordon solongordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohany @cockroach-teamcity @solongordon