exec: fix LIKE handling for patterns like '%a%' #38911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetLikeOperator was choosing the wrong operator when both the first and last characters of the pattern were wildcards. I fixed this logic and improved the unit tests to cover GetLikeOperator rather than just the underlying operators. While I was here I also added better handling for the case where there are no wildcards, i.e. exact string matching. Fixes cockroachdb#38888 Release note: None
|
This change is |
jordanlewis
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
|
bors r+ |
yuzefovich
reviewed
Jul 16, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/sql/exec/like_ops_test.go, line 78 at r1 (raw file):
}, { pattern: "%e%",
We should test "mixed" cases like %e_ and _e%. It seems to me that such cases are not handled (or I'm not seeing it).
craig bot
pushed a commit
that referenced
this pull request
Jul 16, 2019
38908: exec: Fix type ambiguity error out for IN and NOT IN. r=jordanlewis a=rohany A previous PR introduced this error, this PR fixes it and adds a regression test. Release note: None 38911: exec: fix LIKE handling for patterns like '%a%' r=solongordon a=solongordon GetLikeOperator was choosing the wrong operator when both the first and last characters of the pattern were wildcards. I fixed this logic and improved the unit tests to cover GetLikeOperator rather than just the underlying operators. While I was here I also added better handling for the case where there are no wildcards, i.e. exact string matching. Fixes #38888 Release note: None Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu> Co-authored-by: Solon Gordon <solon@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetLikeOperator was choosing the wrong operator when both the first and
last characters of the pattern were wildcards. I fixed this logic and
improved the unit tests to cover GetLikeOperator rather than just the
underlying operators.
While I was here I also added better handling for the case where there
are no wildcards, i.e. exact string matching.
Fixes #38888
Release note: None