exec: fix float comparison for -0 #38912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We got too fancy with our float comparison function, so it was not handling the 0 == -0 case because those values have different bit representations. Release note: None
|
This change is |
jordanlewis
reviewed
Jul 16, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @yuzefovich)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 16, 2019
38912: exec: fix float comparison for -0 r=solongordon a=solongordon We got too fancy with our float comparison function, so it was not handling the 0 == -0 case because those values have different bit representations. Release note: None Co-authored-by: Solon Gordon <solon@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got too fancy with our float comparison function, so it was not
handling the 0 == -0 case because those values have different bit
representations.
Release note: None