exec: dump stack trace for unexpected internal errors #38956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
|
This change is |
yuzefovich
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
This is useful, thanks!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 18, 2019
38956: exec: dump stack trace for unexpected internal errors r=jordanlewis a=jordanlewis Before: `pq: internal error: unexpected error from the vectorized runtime: interface conversion: coldata.column is []bool, not []float64` After: ``` pq: internal error: unexpected error from the vectorized runtime: interface conversion: coldata.column is []bool, not []float64 DETAIL: stack trace: github.com/cockroachdb/cockroach/pkg/sql/exec/error.go:56: func1() runtime/panic.go:522: gopanic() runtime/iface.go:248: panicdottypeE() github.com/cockroachdb/cockroach/pkg/sql/exec/coldata/vec.go:218: Float64() github.com/cockroachdb/cockroach/pkg/sql/exec/projection_ops.eg.go:10797: Next() github.com/cockroachdb/cockroach/pkg/sql/exec/projection_ops.eg.go:10980: Next() github.com/cockroachdb/cockroach/pkg/sql/exec/case.go:68: Next() github.com/cockroachdb/cockroach/pkg/sql/exec/projection_ops.eg.go:10786: Next() github.com/cockroachdb/cockroach/pkg/sql/exec/projection_ops.eg.go:10980: Next() github.com/cockroachdb/cockroach/pkg/sql/exec/simple_project.go:77: Next() github.com/cockroachdb/cockroach/pkg/sql/exec/fn_op.go:32: Next() github.com/cockroachdb/cockroach/pkg/sql/exec/one_shot.go:37: Next() github.com/cockroachdb/cockroach/pkg/sql/exec/aggregator.go:275: Next() github.com/cockroachdb/cockroach/pkg/sql/exec/projection_ops.eg.go:10884: Next() github.com/cockroachdb/cockroach/pkg/sql/exec/projection_ops.eg.go:11126: Next() github.com/cockroachdb/cockroach/pkg/sql/exec/simple_project.go:77: Next() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/materializer.go:106: nextBatch() github.com/cockroachdb/cockroach/pkg/sql/exec/error.go:76: CatchVectorizedRuntimeError() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/materializer.go:113: Next() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/base.go:171: Run() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/processors.go:793: Run() github.com/cockroachdb/cockroach/pkg/sql/distsqlrun/flow.go:658: Run() github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:299: Run() github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:882: PlanAndRun() github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:902: execWithDistSQLEngine() github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:734: dispatchToExecutionEngine() github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:417: execStmtInOpenState() github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:99: execStmt() github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1204: execCmd() github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1140: run() github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:442: ServeConn() github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:580: func1() HINT: You have encountered an unexpected error. Please check the public issue tracker to check whether this problem is already tracked. If you cannot find it there, please report the error with details by creating a new issue. If you would rather not post publicly, please contact us directly using the support form. We appreciate your feedback. ``` Release note: None Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
pq: internal error: unexpected error from the vectorized runtime: interface conversion: coldata.column is []bool, not []float64After:
Release note: None