opt: compute join output col map properly #39052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
|
bors r+ |
Build failed |
rytaft
approved these changes
Jul 24, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:
Fixes cockroachdb#39010. This manifested with the advent of WITH, but the problem was actually that we were computing a join output map somewhat incorrectly. This never actually caused problems before because we would prune any columns that could cause there to be a disparity between the two ways of computing the size of the ColMap, but since WITH doesn't support pruning, it caused issues. I also replaced some other uses of Len that were potentially sketchy. Release note: None
|
Shoudl we re-bors this? |
|
oops, yup, meant to. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 29, 2019
39052: opt: compute join output col map properly r=justinj a=justinj Fixes #39010. This manifested with the advent of WITH, but the problem was actually that we were computing a join output map somewhat incorrectly. This never actually caused problems before because we would prune any columns that could cause there to be a disparity between the two ways of computing the size of the ColMap, but since WITH doesn't support pruning, it caused issues. I also replaced some other uses of Len that were potentially sketchy. Release note: None Co-authored-by: Justin Jaffray <justin@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39010.
This manifested with the advent of WITH, but the problem was actually
that we were computing a join output map somewhat incorrectly. This
never actually caused problems before because we would prune any columns
that could cause there to be a disparity between the two ways of
computing the size of the ColMap, but since WITH doesn't support
pruning, it caused issues.
I also replaced some other uses of Len that were potentially sketchy.
Release note: None