storage: expose quota release queue and base index #39111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes the information on `_status/range/N`. I've looked at a few ranges locally and I'm already noticing that weirdly often the last index will be significantly ahead of the quota release base index (though the release queue is always empty). This might be something that only happens on single-node instances (the release mechanism is based on Ready handling, which is different in single instances because nothing ever needs to get acked externally), but it's unexpected to me. Motivated by cockroachdb#39022, where we see a proposal quota leak: quota is queued up for release, but the base index is way ahead of the last index, so it will never be released. Release note: None
|
This change is |
ajwerner
approved these changes
Jul 26, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
|
CI flake unrelated, filed issue #39112 bors r=ajwerner |
craig bot
pushed a commit
that referenced
this pull request
Jul 26, 2019
39111: storage: expose quota release queue and base index r=ajwerner a=tbg This exposes the information on `_status/range/N`. I've looked at a few ranges locally and I'm already noticing that weirdly often the last index will be significantly ahead of the quota release base index (though the release queue is always empty). This might be something that only happens on single-node instances (the release mechanism is based on Ready handling, which is different in single instances because nothing ever needs to get acked externally), but it's unexpected to me. Motivated by #39022, where we see a proposal quota leak: quota is queued up for release, but the base index is way ahead of the last index, so it will never be released. Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the information on
_status/range/N.I've looked at a few ranges locally and I'm already noticing that
weirdly often the last index will be significantly ahead of the
quota release base index (though the release queue is always empty).
This might be something that only happens on single-node instances (the
release mechanism is based on Ready handling, which is different in
single instances because nothing ever needs to get acked externally),
but it's unexpected to me.
Motivated by #39022, where we see a proposal quota leak: quota is queued
up for release, but the base index is way ahead of the last index, so it
will never be released.
Release note: None