sql: add fk downgrade path for mixed version clusters #39448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@lucy-zhang I just figured I'd get started on this - I forgot we had already gone through and marked all of the write path spots with the new |
jordanlewis
force-pushed
the
fk-downgrade-gate
branch
6 times, most recently
from
934be92
to
b4dbeeb
Compare
If a cluster is in a mixed-version state, and it has new-style foreign keys, all descriptors will be downgraded before serialization. This will be a no-op until code is added that populates the new-style foreign key fields. Release note: None
jordanlewis
force-pushed
the
fk-downgrade-gate
branch
from
b4dbeeb
to
e2941cd
Compare
thoszhang
approved these changes
Aug 9, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 9, 2019
39448: sql: add fk downgrade path for mixed version clusters r=jordanlewis a=jordanlewis If a cluster is in a mixed-version state, and it has new-style foreign keys, all descriptors will be downgraded before serialization. This will be a no-op until code is added that populates the new-style foreign key fields. Release note: None Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a cluster is in a mixed-version state, and it has new-style foreign
keys, all descriptors will be downgraded before serialization. This will
be a no-op until code is added that populates the new-style foreign key
fields.
Release note: None