workload/bank: batch initial row generation

[danhhz]

Release note: None

[cockroach-teamcity]

This change is 

[nvanbenschoten]

Reviewed 6 of 6 files at r1.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @danhhz)

---

pkg/workload/bank/bank.go, line 129 at r1 (raw file):

// Tables implements the Generator interface.
func (b *bank) Tables() []workload.Table {
	numBatches := int(math.Ceil(float64(b.rows) / float64(b.batchSize)))

Float arithmetic seems like it could cause issues. I'd favor integer arithmetic for something like this:

numBatches := (b.rows + b.batchSize - 1) / b.batchSize // ceil(b.rows/b.batchSize)

[danhhz]

TFTR!

bors r=nvanbenschoten

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @nvanbenschoten)

---

pkg/workload/bank/bank.go, line 129 at r1 (raw file):

Previously, nvanbenschoten (Nathan VanBenschoten) wrote…

Float arithmetic seems like it could cause issues. I'd favor integer arithmetic for something like this:

numBatches := (b.rows + b.batchSize - 1) / b.batchSize // ceil(b.rows/b.batchSize)

Whoops, totally agree. I meant to go back and do that myself before I PR'd this and forgot. Done

[craig]

Build failed

• GitHub CI (Cockroach)

[danhhz]

Fixed my broken tests

bors r=nvanbenschoten

[craig]

Build failed

• GitHub CI (Cockroach)

[danhhz]

Flake is #39653

bors r=nvanbenschoten

[craig]

Build succeeded

• GitHub CI (Cockroach)