allow TPC-C partition behavior for clients when data is not partitioned #39803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten and @sploiselle)
pkg/workload/tpcc/tpcc.go, line 143 at r1 (raw file):
)) g.flags.IntVar(&g.partitions, `partitions`, 1, `Partition tables`) g.flags.IntVar(&g.clientPartitions, `client-partitions`, -1, `Make client behave as if the tables are partitioned, but does not actually partition underlying data. Requires --partition-affinity.`)
Default this to 0, since that's what we're using as the condition to indicate that it's not active.
pkg/workload/tpcc/tpcc.go, line 190 at r1 (raw file):
return errors.Errorf(`cannot specify both --partitions and --client-partitions; --partitions actually partitions underlying data. --client-partitons only modifies client behavior to access a subset of warehouses. Must be used with --partition-afinity`)
s/partitons/partitions/
s/afinity/affinity/
pkg/workload/tpcc/tpcc.go, line 560 at r1 (raw file):
} var partitionDBs [][]*workload.MultiConnPool
nit: remove this stray line.
|
bors r+ |
Build failed |
|
Could you add: to your commit message? I think bors might be complaining about that. |
Release justification: workload-only change. Release note: None
|
bors r=nvanbenschoten |
Build failed (retrying...) |
Build failed |
|
bors r=nvanbenschoten |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Sep 19, 2019
39803: allow TPC-C partition behavior for clients when data is not partitioned r=nvanbenschoten a=sploiselle Currently, you can only get multiple clients to "collaborate" on a TPC-C run when the actual underlying Cockroach cluster is partitioned. This PR introduces a `--client-partition` flag that lets a client behave in the same way, even when the data isn't partitioned. The motivation behind this is showing the degraded TPC-C performance of a CockcroachDB cluster when the data isn't partitioned. With the prior configuration, this wasn't possible. I believe this belongs in the repo rather than on a branch because similar types of tests might be useful in the future. Release note: None Release justification: workload-only change. 40802: workload: remove index hints from TPC-C r=RaduBerinde a=sploiselle The heuristic planner benefitted from index hints in some TPC-C statements, but they're now vestigial with the new optimizer. I have removed them to alleviate some of the fussiness of manipulating TPC-C for things like PostgreSQL compatibility. Release note: None Release justification: workload-only change. Co-authored-by: Sean Loiselle <himself@seanloiselle.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you can only get multiple clients to "collaborate" on a TPC-C run when the actual underlying Cockroach cluster is partitioned. This PR introduces a
--client-partitionflag that lets a client behave in the same way, even when the data isn't partitioned.The motivation behind this is showing the degraded TPC-C performance of a CockcroachDB cluster when the data isn't partitioned. With the prior configuration, this wasn't possible.
I believe this belongs in the repo rather than on a branch because similar types of tests might be useful in the future.
Release note: None
Release justification: workload-only change.