sql: Bugfixes and increased tests for IndexSkipTableReader #39833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
asubiotto
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Awesome, thanks for looking into this. 
copy code.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @asubiotto and @rohany)
pkg/sql/distsqlrun/index_skip_table_reader.go, line 218 at r1 (raw file):
// so that we skip all values with the same prefix, and "skip" to the // next distinct value. t.spans[t.currentSpan].Key = key.PrefixEnd()
Since PrefixEnd creates a copy and modifies that, I think we could remove the copy I added.
rohany
force-pushed
the
index-skip-tests
branch
from
1d42f9f
to
873715c
Compare
Fixes cockroachdb#39659. Release note: None
rohany
force-pushed
the
index-skip-tests
branch
from
873715c
to
1fff1d0
Compare
|
bors r=asubiotto |
craig bot
pushed a commit
that referenced
this pull request
Aug 23, 2019
39833: sql: Bugfixes and increased tests for IndexSkipTableReader r=asubiotto a=rohany I investigated the index skip table reader and added some additional tests for null / maximal key handling. It turns out that the for loop we had was incorrect anyway, and PrefixEnd did what was needed. Fixes #39659. Release note: None Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I investigated the index skip table reader and added some additional tests for null / maximal key handling. It turns out that the for loop we had was incorrect anyway, and PrefixEnd did what was needed.
Fixes #39659.
Release note: None