exec: Fix indexing panic in cast #40502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cast operator could panic sometimes due to mismatched column sizes in a batch. Re-slicing the column to the length of the batch should ensure that this cannot happen anymore. Fixes cockroachdb#40461. Release note: None
|
This change is |
jordanlewis
reviewed
Sep 5, 2019
| @@ -134,6 +134,7 @@ func (c *castOp_FROMTYPE_TOTYPE) Next(ctx context.Context) coldata.Batch { | |||
| } | |||
| } | |||
| } else { | |||
| col = col[:n] | |||
There was a problem hiding this comment.
This needs to be col = execgen.SLICE(col, 0, int(n)), since not all types will be normally sliceable like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cast operator could panic sometimes due to mismatched
column sizes in a batch. Re-slicing the column to the length
of the batch should ensure that this cannot happen anymore.
Fixes #40461.
Release note: None