exec: make the output of explain(vec) more compact #40565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
approved these changes
Sep 7, 2019
There was a problem hiding this comment.
Very nice!
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
jordanlewis
force-pushed
the
compact-explain
branch
from
0c00792
to
ab1f384
Compare
|
bors r+ |
Build failed |
The treeprinter was extended to learn about different indentation width, and explain(vec) now uses a rather compact setting. Release note: None
jordanlewis
force-pushed
the
compact-explain
branch
from
ab1f384
to
426731a
Compare
|
bors r+ |
Build failed |
|
Flake in TestDockerCLI? bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 8, 2019
40565: exec: make the output of explain(vec) more compact r=jordanlewis a=jordanlewis The treeprinter was extended to learn about different indentation width, and explain(vec) now uses a rather compact setting. Release note: None Co-authored-by: Jordan Lewis <jordanthelewis@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The treeprinter was extended to learn about different indentation width,
and explain(vec) now uses a rather compact setting.
Release note: None