opt: fix scalar building error handling #40617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are incorrectly returning `nil` error in an error case. This leads to an assertion error instead of a "could not decorrelate subquery" error. Fixes cockroachdb#40590. Release note: None
|
This change is |
rytaft
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @justinj)
justinj
reviewed
Sep 10, 2019
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 10, 2019
40609: roachtest: update 19.1 hibernate blacklist r=rafiss a=rafiss The blacklist had too many expected failures. Most of them were related to earlier issues with the test being unable to connect to the cluster. Also, remove the `--info` option from the test runner command, since it makes too much output. touches #40538 Release note: None 40617: opt: fix scalar building error handling r=RaduBerinde a=RaduBerinde We are incorrectly returning `nil` error in an error case. This leads to an assertion error instead of a "could not decorrelate subquery" error. Fixes #40590. Release note: None 40619: cliccl: Change license acquisition URL r=rohany a=rohany Change the cockroach demo license acquisition URLs to point to a new URL. Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: Rohan Yadav <rohany@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are incorrectly returning
nilerror in an error case. This leadsto an assertion error instead of a "could not decorrelate subquery"
error.
Fixes #40590.
Release note: None