sql: another syntax hint for ALTER PARTITION #40812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user tries to specify an index in ALTER PARTITION ... OF TABLE, they now receive a hint to use ALTER PARTITION ... OF INDEX instead. I added similar logic recently but only for the index wildcard syntax, <tablename>@*. Release justification: Low-risk error messaging improvement Release note: None
|
cc @awoods187 |
|
This change is |
rohany
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
lgtm
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @rohany)
|
thanks solon!
…On Mon, Sep 16, 2019 at 4:59 PM Rohan Yadav ***@***.***> wrote:
***@***.**** approved this pull request.
lgtm
*Reviewable
<https://reviewable.io/reviews/cockroachdb/cockroach/40812#-:-Lovrjp76VAwbhILy-nK:bb7k0qh>*
status: [image:
] complete! 0 of 0 LGTMs obtained (waiting on
@rohany <https://github.com/rohany>)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40812?email_source=notifications&email_token=AFJ7F73AKXPQ522LPPJZJ5TQJ7XTRA5CNFSM4IXHDPNKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE4DQ6A#pullrequestreview-288897144>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFJ7F75CJ5EBNOXCH2U2ZBLQJ7XTRANCNFSM4IXHDPNA>
.
--
Andy Woods
Product Manager, Cockroach Labs
andy@cockroachlabs.com
|
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 18, 2019
40812: sql: another syntax hint for ALTER PARTITION r=solongordon a=solongordon If a user tries to specify an index in ALTER PARTITION ... OF TABLE, they now receive a hint to use ALTER PARTITION ... OF INDEX instead. I added similar logic recently but only for the index wildcard syntax, <tablename>@*. Release justification: Low-risk error messaging improvement Release note: None Co-authored-by: Solon Gordon <solon@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user tries to specify an index in ALTER PARTITION ... OF TABLE,
they now receive a hint to use ALTER PARTITION ... OF INDEX instead.
I added similar logic recently but only for the index wildcard syntax,
@*.
Release justification: Low-risk error messaging improvement
Release note: None