sql: fix bug with needed column families and nulls #41212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rohany
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis and @rohany)
When doing point lookups, we have logic to only scan column families which are needed for the requested columns. However, this logic had a bug concerning NULL values. Column families other than the one with ID 0 do not store a row if all their columns are NULL. This means that if you only scan those families, you can't distinguish between the absence of a row and all NULL values. Since we didn't account for this, some queries which should have returned an all NULL row were instead returning no row. See the referenced issue for specific examples. For now I have fixed this by always including column family 0 in the needed column families. There are some special cases where we could omit it, but we'll save those for the 20.1 release. Fixes cockroachdb#41007 Release note: None Release justification: Correctness bug fix
solongordon
force-pushed
the
needed-families-fix-19.2
branch
from
5de839d
to
c55524d
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 1, 2019
41212: sql: fix bug with needed column families and nulls r=solongordon a=solongordon When doing point lookups, we have logic to only scan column families which are needed for the requested columns. However, this logic had a bug concerning NULL values. Column families other than the one with ID 0 do not store a row if all their columns are NULL. This means that if you only scan those families, you can't distinguish between the absence of a row and all NULL values. Since we didn't account for this, some queries which should have returned an all NULL row were instead returning no row. See the referenced issue for specific examples. For now I have fixed this by always including column family 0 in the needed column families. There are some special cases where we could omit it, but we'll save those for the 20.1 release. Fixes #41007 Release note: None Release justification: Correctness bug fix Co-authored-by: Solon Gordon <solon@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing point lookups, we have logic to only scan column families
which are needed for the requested columns. However, this logic had a
bug concerning NULL values. Column families other than the one with ID 0
do not store a row if all their columns are NULL. This means that if you
only scan those families, you can't distinguish between the absence of a
row and all NULL values. Since we didn't account for this, some queries
which should have returned an all NULL row were instead returning no
row. See the referenced issue for specific examples.
For now I have fixed this by always including column family 0 in the
needed column families. There are some special cases where we could omit
it, but we'll save those for the 20.1 release.
Fixes #41007
Release note: None
Release justification: Correctness bug fix