workload: don't panic on limiter error #41354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Oct 7, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
`limiter.Wait` can throw the error `Wait(n=1) would exceed context deadline` if it is asked to wait for longer than a context deadline. This seems to happen reliably with a workload wait of 2m. There's no reason we need to turn this into an panic. Release justification: Testing only. Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/workloadRampWait
branch
from
e3d037a
to
2034c5b
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 7, 2019
41354: workload: don't panic on limiter error r=nvanbenschoten a=nvanbenschoten `limiter.Wait` can throw the error `Wait(n=1) would exceed context deadline` if it is asked to wait for longer than a context deadline. This seems to happen reliably with a workload wait of 2m. There's no reason we need to turn this into an panic. Release justification: Testing only. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
limiter.Waitcan throw the errorWait(n=1) would exceed context deadlineif it is asked to wait for longer than a context deadline. This seems to
happen reliably with a workload wait of 2m. There's no reason we need to
turn this into an panic.
Release justification: Testing only.
Release note: None