roachtest: Fix error reporting in kv50 test #41480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When one thread in a monitor fatals and another returns an error, the fatal is the one that gets reported, even if it's an unhelpful "signal: killed" from a cancelled process that was caused by a previously returned error. Whenever any thread returns errors, they all should, by using RunE instead of Run, etc. This is probably a much more widespread problem in the roachtests, but for now I'm only fixing this one which is causing opaque failures in cockroachdb#40359 Release note: None
|
This change is |
|
I think this is a duplicate of #41106, which I've been struggling to get merged. I'll give it another push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one thread in a monitor fatals and another returns an error, the
fatal is the one that gets reported, even if it's an unhelpful
"signal: killed" from a cancelled process that was caused by a
previously returned error. Whenever any thread returns errors, they
all should, by using RunE instead of Run, etc. This is probably a much
more widespread problem in the roachtests, but for now I'm only fixing
this one which is causing opaque failures in #40359
Release note: None