settings/cluster: introducing the 19.2 cluster version #41935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andreimatei
force-pushed
the
19.2-version19.2
branch
2 times, most recently
from
b950256
to
2b2f7b8
Compare
This is not a backport; it's original work on the release-19.2 branch. The corresponding work on master is cockroachdb#41931. I've had to skip a test because it was validating that we've removed all the versions introduced before 19.1, since they're now "always active". Work to remove those versions is in progress on master. Release note: None
andreimatei
force-pushed
the
19.2-version19.2
branch
from
2b2f7b8
to
d179047
Compare
tbg
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @andreimatei and @bdarnell)
pkg/server/version_cluster_test.go, line 141 at r1 (raw file):
func prev(version roachpb.Version) roachpb.Version { if version.Unstable != 0 { return roachpb.Version{Major: version.Major, Minor: version.Minor}
Also, prev(19.1.4) should equal prev(19.1)
andreimatei
commented
Oct 28, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/server/version_cluster_test.go, line 141 at r1 (raw file):
Previously, tbg (Tobias Grieger) wrote…
Also, prev(19.1.4) should equal prev(19.1)
I didn't add that to the comment because it's covered by prev(2.1-5) == 2.1 (although perhaps not so obviously)
knz
added a commit
to knz/cockroach
that referenced
this pull request
Nov 10, 2019
Prior to this patch, the release note script would skip over
standalone commits (without a PR) when extracting release notes.
This was defective, as the git history does have a few example
standalone commits, with release note but without PR.
Additionally, the script now reports PRs that are missing release
notes *or only use 'Release note: none'*, which may indicate
that the engineer did not bother filling in a note despite the
presence of a user-facing change.
For example:
```
$ python3 scripts/release-notes.py \
--from v19.2.0-beta.20190930 \
--until provisional_201911080435_v19.2.0-rc.5
```
Outputs (snippet):
- Andrei Matei:
- 2019-10-04 [cockroachdb#41303][cockroachdb#41303] [ca32e6f][ca32e6f] sql: remove dead code [NO RELEASE NOTE]
- 2019-10-05 [cockroachdb#41307][cockroachdb#41307] [1c99165][1c99165] sql: fix various problematic uses of the txn in DistSQL flows (4 commits)
- 2019-10-28 [cockroachdb#41935][cockroachdb#41935] [bad8e55][bad8e55] settings/cluster: introducing the 19.2 cluster version [NO RELEASE NOTE]
In this example, the first PR has no release note but does not deserve
one. The second has a release note. The third is marked with "Release
note: None" but **there should really have been a release note**: the
introduction of the major cluster version is an important user-facing
change and should be announced.
By highlighting the missing release notes in this way, the script
gives an opportunity to the doc writer(s) to find additional
user-facing changes that need to be documented.
[cockroachdb#41303]: cockroachdb#41303
[cockroachdb#41307]: cockroachdb#41307
[cockroachdb#41935]: cockroachdb#41935
[ca32e6f]: cockroachdb@ca32e6ff0
[1c99165]: cockroachdb@1c99165c3
[bad8e55]: cockroachdb@bad8e55bb
Release note: None
This was referenced Nov 10, 2019
knz
added a commit
to knz/cockroach
that referenced
this pull request
Nov 12, 2019
Prior to this patch, the release note script would skip over
standalone commits (without a PR) when extracting release notes.
This was defective, as the git history does have a few example
standalone commits, with release note but without PR.
Additionally, the script now reports PRs that are missing release
notes *or only use 'Release note: none'*, which may indicate
that the engineer did not bother filling in a note despite the
presence of a user-facing change.
For example:
```
$ python3 scripts/release-notes.py \
--from v19.2.0-beta.20190930 \
--until provisional_201911080435_v19.2.0-rc.5
```
Outputs (snippet):
- Andrei Matei:
- 2019-10-04 [cockroachdb#41303][cockroachdb#41303] [ca32e6f][ca32e6f] sql: remove dead code [NO RELEASE NOTE]
- 2019-10-05 [cockroachdb#41307][cockroachdb#41307] [1c99165][1c99165] sql: fix various problematic uses of the txn in DistSQL flows (4 commits)
- 2019-10-28 [cockroachdb#41935][cockroachdb#41935] [bad8e55][bad8e55] settings/cluster: introducing the 19.2 cluster version [NO RELEASE NOTE]
In this example, the first PR has no release note but does not deserve
one. The second has a release note. The third is marked with "Release
note: None" but **there should really have been a release note**: the
introduction of the major cluster version is an important user-facing
change and should be announced.
By highlighting the missing release notes in this way, the script
gives an opportunity to the doc writer(s) to find additional
user-facing changes that need to be documented.
[cockroachdb#41303]: cockroachdb#41303
[cockroachdb#41307]: cockroachdb#41307
[cockroachdb#41935]: cockroachdb#41935
[ca32e6f]: cockroachdb@ca32e6ff0
[1c99165]: cockroachdb@1c99165c3
[bad8e55]: cockroachdb@bad8e55bb
Release note: None
knz
added a commit
to knz/cockroach
that referenced
this pull request
Nov 12, 2019
Prior to this patch, the release note script would skip over
standalone commits (without a PR) when extracting release notes.
This was defective, as the git history does have a few example
standalone commits, with release note but without PR.
Additionally, the script now reports PRs that are missing release
notes *or only use 'Release note: none'*, which may indicate
that the engineer did not bother filling in a note despite the
presence of a user-facing change.
For example:
```
$ python3 scripts/release-notes.py \
--from v19.2.0-beta.20190930 \
--until provisional_201911080435_v19.2.0-rc.5
```
Outputs (snippet):
- Andrei Matei:
- 2019-10-04 [cockroachdb#41303][cockroachdb#41303] [ca32e6f][ca32e6f] sql: remove dead code [NO RELEASE NOTE]
- 2019-10-05 [cockroachdb#41307][cockroachdb#41307] [1c99165][1c99165] sql: fix various problematic uses of the txn in DistSQL flows (4 commits)
- 2019-10-28 [cockroachdb#41935][cockroachdb#41935] [bad8e55][bad8e55] settings/cluster: introducing the 19.2 cluster version [NO RELEASE NOTE]
In this example, the first PR has no release note but does not deserve
one. The second has a release note. The third is marked with "Release
note: None" but **there should really have been a release note**: the
introduction of the major cluster version is an important user-facing
change and should be announced.
By highlighting the missing release notes in this way, the script
gives an opportunity to the doc writer(s) to find additional
user-facing changes that need to be documented.
[cockroachdb#41303]: cockroachdb#41303
[cockroachdb#41307]: cockroachdb#41307
[cockroachdb#41935]: cockroachdb#41935
[ca32e6f]: cockroachdb@ca32e6ff0
[1c99165]: cockroachdb@1c99165c3
[bad8e55]: cockroachdb@bad8e55bb
Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a backport; it's original work on the release-19.2 branch.
The corresponding work on master is #41931.
I've had to skip a test because it was validating that we've removed all
the versions introduced before 19.1, since they're now "always active".
Work to remove those versions is in progress on master.
Release note: None