roachprod: fix use of GCE_PROJECT #42673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That env var was supposed to allow one to set the project to use, but it got broken a while ago. Release note: None
|
This change is |
ajwerner
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 21, 2019
42633: builtins: support current_timestamp with precision r=otan a=otan Resolves #32098 Release note (sql change): This PR adds new functionality that allows users to use CURRENT_TIMESTAMP with a given precision from 0-6, e.g. `SELECT CURRENT_TIMESTAMP(4)`. 42673: roachprod: fix use of GCE_PROJECT r=andreimatei a=andreimatei That env var was supposed to allow one to set the project to use, but it got broken a while ago. Release note: None Co-authored-by: Oliver Tan <otan@cockroachlabs.com> Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That env var was supposed to allow one to set the project to use, but it
got broken a while ago.
Release note: None