cli: remove auto-init with cockroach start without --join
#44112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I'm expecting a bunch of tests to fail, and I'll fix them. |
knz
force-pushed
the
20200119-disable-auto-init
branch
from
fdf4f86
to
a231155
Compare
knz
changed the title
cockroach start without --joincockroach start without --join
knz
force-pushed
the
20200119-disable-auto-init
branch
2 times, most recently
from
cadc032
to
6695bb7
Compare
|
Some items identified by the CI failures:
|
Release note (backward-incompatible change): A CockroachDB node started with `cockroach start` without the `--join` flag no longer automatically initializes the cluster. The `cockrach init` command is now mandatory. The auto-initialization behavior had been deprecated in version 19.2. Users can start `cockroach start-single-node` to start and auto-initialize a single-node cluster.
knz
force-pushed
the
20200119-disable-auto-init
branch
from
6695bb7
to
085ecbf
Compare
|
Ooo, this might make things a little less messy in #44249. Any guesses on timeline for this merging? |
|
I'd say end of February unless re-prioritized
--
Verstuurd vanaf mijn Android apparaat met K-9 Mail. Excuseer mijn beknoptheid.
|
9 tasks
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Jul 10, 2020
Fixes cockroachdb#44116. Informs cockroachdb#24118. Reviving cockroachdb#44112. Release note (backward-incompatible change): A CockroachDB node started with cockroach start without the --join flag no longer automatically initializes the cluster. The cockrach init command is now mandatory. The auto-initialization behavior had been deprecated in version 19.2.
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Jul 15, 2020
Fixes cockroachdb#44116. Informs cockroachdb#24118. Reviving cockroachdb#44112. We remove the deprecated behavior of crdb where we previously auto-initialized the cluster when `cockroach start` was invoked without a corresponding `--join` flag. We update a few tests along the way that made use of this behavior by changing them to either explicitly init, or now lean on `roachprod` changes (from cockroachdb#51329) that transparently manage initialization. Release note (backward-incompatible change): A CockroachDB node started with cockroach start without the --join flag no longer automatically initializes the cluster. The `cockroach init` command is now mandatory. The auto-initialization behavior had been deprecated in version 19.2. Release note (backward-incompatible change): `cockroach start` without `--join` is no longer supported. It was deprecated in a previous release.
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Jul 17, 2020
Fixes cockroachdb#44116. Informs cockroachdb#24118. Reviving cockroachdb#44112. We remove the deprecated behavior of crdb where we previously auto-initialized the cluster when `cockroach start` was invoked without a corresponding `--join` flag. We update a few tests along the way that made use of this behavior by changing them to either explicitly init, or now lean on `roachprod` changes (from cockroachdb#51329) that transparently manage initialization. Release note (backward-incompatible change): A CockroachDB node started with cockroach start without the --join flag no longer automatically initializes the cluster. The `cockroach init` command is now mandatory. The auto-initialization behavior had been deprecated in version 19.2. Release note (backward-incompatible change): `cockroach start` without `--join` is no longer supported. It was deprecated in a previous release.
|
Superseded by #51245 |
craig bot
pushed a commit
that referenced
this pull request
Jul 17, 2020
51245: cli: remove auto-init with `cockroach start` without `--join` r=irfansharif a=irfansharif Fixes #44116. Informs #24118. Reviving #44112. Release note (backward-incompatible change): A CockroachDB node started with cockroach start without the --join flag no longer automatically initializes the cluster. The cockrach init command is now mandatory. The auto-initialization behavior had been deprecated in version 19.2. Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44116.
Informs #24118.
Release note (backward-incompatible change): A CockroachDB node
started with
cockroach startwithout the--joinflag nolonger automatically initializes the cluster. The
cockrach initcommand is now mandatory. The auto-initialization behavior had
been deprecated in version 19.2.